New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][CMake] 16.0.0: build fails because missing boost detection #41624
Comments
BTW looks like 16.1.0 dist tarball has not been uploaded to https://dist.apache.org/repos/dist/release/arrow/ |
Boost wasn't found (correctly), you can set 16.1.0 is still in the release vote so it makes senses that it's not uploaded yet. |
OK my mistake (I've been looking for 'boost` (all lowercase). |
Have you tried my suggestion? And do you have boost installed? If so which version and where? |
I've solved that by add boost devel repackage to build env but issue still remains as I've defined that: cmake finished with exit 0 without boost found. |
Looking on cmake output:
I think that all those bundled bits should be replaced by simple detection and all those detections should exit with non-zero if some needed component has not been found. |
Could you try this? diff --git a/cpp/src/parquet/CMakeLists.txt b/cpp/src/parquet/CMakeLists.txt
index 93f2e72d8d..28d9991629 100644
--- a/cpp/src/parquet/CMakeLists.txt
+++ b/cpp/src/parquet/CMakeLists.txt
@@ -262,13 +262,13 @@ if(NOT PARQUET_MINIMAL_DEPENDENCY)
# These are libraries that we will link privately with parquet_shared (as they
# do not need to be linked transitively by other linkers)
- list(APPEND PARQUET_SHARED_PRIVATE_LINK_LIBS thrift::thrift)
+ list(APPEND PARQUET_SHARED_PRIVATE_LINK_LIBS thrift::thrift Boost::headers)
# Link publicly with parquet_static (because internal users need to
# transitively link all dependencies)
- list(APPEND PARQUET_STATIC_LINK_LIBS thrift::thrift)
+ list(APPEND PARQUET_STATIC_LINK_LIBS thrift::thrift Boost::headers)
if(NOT THRIFT_VENDORED)
- list(APPEND PARQUET_STATIC_INSTALL_INTERFACE_LIBS thrift::thrift)
+ list(APPEND PARQUET_STATIC_INSTALL_INTERFACE_LIBS thrift::thrift Boost::headers)
endif()
endif()
if(ARROW_WITH_OPENTELEMETRY) |
Describe the bug, including details regarding any error messages, version, and platform.
cmake output looks like do not shows any tries to detect
boost
and build fails because missing boost in build env
Component(s)
C++
The text was updated successfully, but these errors were encountered: