Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Helm] make API/Master/Worker/Alert application.yaml configurable on k8s #15473

Closed
3 tasks done
pegasas opened this issue Jan 11, 2024 · 0 comments · Fixed by #15922
Closed
3 tasks done

[Feature][Helm] make API/Master/Worker/Alert application.yaml configurable on k8s #15473

pegasas opened this issue Jan 11, 2024 · 0 comments · Fixed by #15922
Assignees
Labels
feature new feature

Comments

@pegasas
Copy link
Contributor

pegasas commented Jan 11, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

I saw now api/master/worker package application.yaml into docker.
Maybe we can consider let master/worker deployment/stateful directly read from configmap application.yaml

I guess ds now will not fully throw away application.yaml for debugging on local/non k8s deployment mode.
So maybe we could add a stage on CI to read master/worker recources yaml to ingest into helm values.yaml, so that it can be affected on both k8s/non-k8s mode.

so that we can modify configmap for some settings update instead of rebuild docker image?

Use case

Configuration Hot Reloading for some supported future on springapp

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pegasas pegasas added feature new feature Waiting for reply Waiting for reply labels Jan 11, 2024
@fuchanghai fuchanghai removed the Waiting for reply Waiting for reply label Jan 12, 2024
@pegasas pegasas closed this as completed Mar 25, 2024
@pegasas pegasas reopened this Apr 7, 2024
@pegasas pegasas changed the title [Feature][Helm] make API/Master/Worker application.yaml configurable on k8s [Feature][Helm] make API/Master/Worker/Alert application.yaml configurable on k8s Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants