Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Process not destroy in DiskUtils df function #34387

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[fix] Process not destroy in DiskUtils df function #34387

wants to merge 4 commits into from
+50 −22

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented May 3, 2024 •
edited

Proposed changes

Issue Number: close #34386

  1. In DiskUtils df function
    Added Process destroy and buffer read close in finally.
    added UT to verify and cover the code change.
  2. Process not destroy in plsql Exec
    fixed and reviewed.
  3. Process not destroy DppScheduler
    fixed and reviewed

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

Vallishp commented May 3, 2024

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 185551 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b73aa1790006f14762b6cec001061b8bc69f5bd4, data reload: false

query1	936	361	348	348
query2	6531	2444	2270	2270
query3	6658	201	204	201
query4	23090	21802	21892	21802
query5	3894	446	417	417
query6	277	190	168	168
query7	4566	307	298	298
query8	263	189	191	189
query9	8552	2368	2342	2342
query10	413	261	269	261
query11	15281	14682	14656	14656
query12	121	85	87	85
query13	1645	382	364	364
query14	9804	8322	6530	6530
query15	244	165	161	161
query16	8179	252	252	252
query17	1910	550	563	550
query18	2089	288	270	270
query19	323	156	150	150
query20	86	86	85	85
query21	192	126	124	124
query22	5024	4876	4881	4876
query23	34003	33337	33098	33098
query24	10658	2917	2851	2851
query25	587	354	385	354
query26	1134	143	146	143
query27	2350	307	310	307
query28	7192	1983	1982	1982
query29	834	592	598	592
query30	242	147	149	147
query31	935	737	744	737
query32	97	50	51	50
query33	732	244	238	238
query34	1058	477	472	472
query35	803	644	654	644
query36	1039	903	892	892
query37	137	65	68	65
query38	3116	3007	3004	3004
query39	1580	1547	1538	1538
query40	199	126	126	126
query41	40	38	38	38
query42	103	93	92	92
query43	568	551	530	530
query44	1218	740	735	735
query45	263	243	221	221
query46	1070	717	704	704
query47	1935	1863	1833	1833
query48	379	294	291	291
query49	832	411	402	402
query50	753	397	384	384
query51	6774	6716	6697	6697
query52	101	92	89	89
query53	348	272	277	272
query54	336	233	236	233
query55	72	71	72	71
query56	242	213	214	213
query57	1233	1144	1141	1141
query58	217	191	197	191
query59	3558	3168	2971	2971
query60	252	233	229	229
query61	91	85	85	85
query62	650	444	461	444
query63	305	274	280	274
query64	8573	7252	7233	7233
query65	3123	3078	3019	3019
query66	812	328	329	328
query67	15383	15069	14892	14892
query68	5939	534	537	534
query69	544	304	306	304
query70	1130	1148	1051	1051
query71	482	265	267	265
query72	8004	2507	2382	2382
query73	723	318	315	315
query74	6497	6080	6062	6062
query75	3905	2647	2665	2647
query76	4122	1052	933	933
query77	615	258	264	258
query78	10766	10107	10070	10070
query79	6006	511	507	507
query80	1558	435	429	429
query81	501	219	223	219
query82	1576	89	92	89
query83	198	164	160	160
query84	264	87	83	83
query85	1435	291	258	258
query86	455	300	290	290
query87	3306	3088	3090	3088
query88	5054	2411	2405	2405
query89	471	366	380	366
query90	2005	184	180	180
query91	120	99	94	94
query92	56	45	48	45
query93	5286	502	506	502
query94	1132	179	178	178
query95	389	298	304	298
query96	593	264	262	262
query97	3113	2961	2956	2956
query98	231	215	214	214
query99	1206	856	871	856
Total cold run time: 293687 ms
Total hot run time: 185551 ms

@Vallishp
Copy link
Contributor Author

Vallishp commented May 3, 2024

run buildall

@xinyiZzz xinyiZzz self-requested a review May 8, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyiZzz xinyiZzz Awaiting requested review from xinyiZzz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Runtime.getRuntime().exec created process need to be destroyed
2 participants
@Vallishp @doris-robot