Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Workflow engine type "Hop remote workflow engine" can reference itself #3935

Closed
dsanderbi opened this issue May 15, 2024 · 1 comment · Fixed by #3962
Closed

[Bug]: Workflow engine type "Hop remote workflow engine" can reference itself #3935

dsanderbi opened this issue May 15, 2024 · 1 comment · Fixed by #3962

Comments

@dsanderbi
Copy link
Contributor

Apache Hop version?

2.8.0

Java version?

openjdk version "11.0.23" 2024-04-16 LTS

Operating system

Windows

What happened?

Issue Description:

The workflow run configuration for workflow engine type "Hop remote workflow engine" can reference itself.

Incident Details:

This issue occurred with the following workflow:

Hop server is running on a VM (VirtualBox, Ubuntu 24.04, openjdk version "11.0.23" 2024-04-16), default installation with no modifications.
In the Hop GUI (Windows), the server was added via the Metadata button -> Add Hop Server.
The workflow run configuration "test" was created with "Hop remote workflow engine".

Clicking on the "Start execution button" then click on the play button.
This opens the run configuration for "test". Here it is possible to select again "test" as run configuration.
Clicking OK -> Launch results in the following error, see file: log.log

image

Resetting to local run configuration and starting the Workflow again -> pop-up indicates that the workflow is already running.
However the stop button is greyed-out.

image
Later, the stop button becomes visible, but clicking it does not abort the process.
Restarting Hop is required to resume work.

Expected Behavior:

When opening the run options -> edit this metadata
image
it should not be possible to select "test" run configuration again!

Issue Priority

Priority: 2

Issue Component

Component: Hop Gui, Component: Hop Server, Component: Metadata, Component: Workflows

@nadment
Copy link
Contributor

nadment commented May 22, 2024

Same problem for pipeline remote run configuration which can refer to itself

nadment added a commit to nadment/hop that referenced this issue May 22, 2024
@nadment nadment linked a pull request May 22, 2024 that will close this issue
hansva added a commit that referenced this issue May 25, 2024
Remote run configuration refers to itself #3935
@hansva hansva added this to the 2.10 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants