New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] FuryBuilder supports registered classes #1459
Comments
Looks good to me, we can add API for register class by order, register class by id, and register serializer by class. |
One concern is that BaseFury already supports register classes/serializers, do we still need to add this API to FuryBuilder? |
We can extract all WDYT? @chaokunyang |
I perfer not. |
I agree with you, If we don't implement some interfaces in |
I still don't know why users can't invoke |
It is also possible to use Currently, only one user has made this suggestion. We can also observe whether other users make this suggestion in the future. If so, we will consider adjusting the structure to implement this function. We can keep this issue for continuous observation to see if there are any similar suggestions. |
Ok, we can keep the issue open. If the demand for registering classes on FuryBuilder continues grow, we can support it later. And all similar methods such as setClassChecker/setSerializerFactory have similar issues. We should take those API into consideration too. I believe we will receive more feedbacks when we made several releases under ASF. |
Is your feature request related to a problem? Please describe.
Currently, classes can only be registered through the
Fury#register
interface. Could we build Fury and register the class in one go?Some users have reported that classes cannot be registered through
FuryBuilder
. #1458Describe the solution you'd like
Could we support chained(In the process of building Fury) class registration in
FuryBuilder
?Additional context
N / A
The text was updated successfully, but these errors were encountered: