New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sporadic java.lang.ArrayIndexOutOfBoundsException/Can't deserialize lambda if RuntimeException is deserialized #1558
Comments
Hi @johannschenkl , thanks for reporting this bug. It seems that our current implementation has some inconsistency between interpreter mode and codegen mode. This has been reported in #1455, #1325 and #1176. The fix won't be difficult. But none of this can provide reproduction code, so I can't debug to find out what's going wrong. |
Will it still raise execpetion if you disabled asyncCompilation? |
It would be really great if you can provide reproduction code. I try to fix it for a long time |
Hi @chaokunyang, thanks for the quick response. Currently, the issue is only reproducible on a qa machine and only for some users. I was not able to reproduce it by myself. As of yet, it only happend in conjunction with a serialized RuntimeException. |
Hi @johannschenkl . Is this issue still persisits? |
Hi @chaokunyang, unfortunately yes. I'm still trying to get a reproducer working. |
We're self-managing Fury in a ThreadLocal, is that the issue, maybe?
I know there's also the ...buildThreadSafeFury/buildThreadLocalFury implementations. But we did not see a way to register a classchecker on them. |
This is right, or you can use |
## What does this PR do? Some collectionSerializer may overwrite write/read method, then clear element serializer may not got invoked. This PR clears serializer for collection/map to avoid container use wrong serializer for nested elements. ## Related issues #1558 #1455, #1325 and #1176. ## Does this PR introduce any user-facing change? <!-- If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary. --> - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark <!-- When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here. -->
Hi @chaokunyang, sorry for the late response. After using the provided factory & disabling async compilation, the issue did not show up again. |
Search before asking
Version
0.4.1
Component(s)
Java
Minimal reproduce step
We are using fury as a replacement for jdk serialization in a java rpc application. If on the server side an exception is thrown, this exception in serialized and sent to the client.
In some cases we seen and exception when the serialization is done.
Thanks for your help and for that great project!
Fury setup:
var fury = Fury.builder() .withLanguage(Language.JAVA) .withRefTracking(true) .requireClassRegistration(false) .withAsyncCompilation(true).build();
Relevant parts of logs:
What did you expect to see?
The deserialized payload.
What did you see instead?
An ArrayIndexOutOfBoundsException.
Anything Else?
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: