Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid to modify idl generate code in client #1998

Open
shalk opened this issue Apr 30, 2024 · 2 comments
Open

avoid to modify idl generate code in client #1998

shalk opened this issue Apr 30, 2024 · 2 comments
Labels
type/bug This issue reports a bug.

Comments

@shalk
Copy link
Collaborator

shalk commented Apr 30, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

I found java client use 10 idl files, c++ use 12 idl files, go use 11 idl files.

➜  grep 'namespace java' idl/* | wc -l 
      10
➜  grep 'namespace go' idl/* | wc -l
      11
➜  grep 'namespace cpp' idl/* | wc -l
      12

Though java use 10 idl files, but java client only generate 9 idl files code.
This is strange, and hard to maintain.

For java client,
I think either
just remove namespace java from dns.thrift , not use the dns.thrift to generate java code.
or
use the generate code of dns.thrift, modify the java-thrift lib.

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

  2. What did you expect to see?

  3. What did you see instead?

  4. What version of Pegasus are you using?

@shalk shalk added the type/bug This issue reports a bug. label Apr 30, 2024
@acelyc111
Copy link
Member

Maybe it's a mistake, I'll check it later!

@acelyc111
Copy link
Member

@shalk

  1. java client use 10 idl files, c++ use 12 idl files, go use 11 idl files

It's because each language client has different function set. For example, the admin-cli is using go-client to support some CLI commands, but the Java client doesn't have such function. So you can see the go-client use an extra idl/replica_admin.thrift.

  1. Though java use 10 idl files, but java client only generate 9 idl files code

Yes, the dsn.thrift is used for place holder, I'll try to clarify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue reports a bug.
Projects
None yet
Development

No branches or pull requests

2 participants