Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8127]Optimize the metric calculation logic of the time wheel #8128

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8127]Optimize the metric calculation logic of the time wheel #8128

wants to merge 2 commits into from

Conversation

3424672656
Copy link
Contributor

@3424672656 3424672656 commented May 13, 2024 •
edited

Which Issue(s) This PR Fixes

Fixes #8127

Brief Description

How Did You Test This Change?

@3424672656 3424672656 mentioned this pull request May 13, 2024
Open
3 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (6091968) to head (e531415).

Files Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 50.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #8128      +/-   ##
=============================================
- Coverage      42.89%   42.86%   -0.04%     
+ Complexity     10375    10364      -11     
=============================================
  Files           1270     1270              
  Lines          88694    88704      +10     
  Branches       11401    11404       +3     
=============================================
- Hits           38048    38020      -28     
- Misses         45954    45977      +23     
- Partials        4692     4707      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3424672656 3424672656 changed the title [ISSUE #8127]Fix the metric of the time wheel was incorrectly calculated [ISSUE #8127]Optimize the metric calculation logic of the time wheel May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenerousMan GenerousMan GenerousMan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the metric calculation logic of the time wheel
3 participants
@3424672656 @codecov-commenter @GenerousMan