Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][File] Add BaseMultipleFileSink #5970

Closed
2 of 3 tasks
ruanwenjun opened this issue Dec 6, 2023 · 2 comments
Closed
2 of 3 tasks

[Improvement][File] Add BaseMultipleFileSink #5970

ruanwenjun opened this issue Dec 6, 2023 · 2 comments
Labels

Comments

@ruanwenjun
Copy link
Member

ruanwenjun commented Dec 6, 2023

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

Right now, we need to make file related sink connector can support multiple sink.

This need to do sub changes

  1. The sink connector use new Factory API to create Sink. [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on connector #5651
  2. The sink support multiple table API. [Feature][Connector-V2] Support multi-table sink feature #5652

After we modify all file sink connectors, we can create a new BaseMultipleFileSink and move the common method in BaseMultipleFileSink , then remove the current BaseFileSink class.

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Copy link

github-actions bot commented Jan 6, 2024

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 6, 2024
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant