Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for NewGlobalNode#getGlobalRuleNode #28492

Open
zhaojinchao95 opened this issue Sep 21, 2023 · 1 comment · May be fixed by #30899
Open

Add unit test for NewGlobalNode#getGlobalRuleNode #28492

zhaojinchao95 opened this issue Sep 21, 2023 · 1 comment · May be fixed by #30899
Assignees
@Swastyy
Labels
good first issue in: test project: OSD2023 stale status: volunteer wanted

Comments

@zhaojinchao95
Copy link
Contributor

zhaojinchao95 commented Sep 21, 2023 •
edited

Hi community,

This issue is for #28487.

Aim

Add more unit tests for NewGlobalNode to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@zhaojinchao95 zhaojinchao95 changed the title Add unit test for NewGlobalNode#getGlobalRuleNode(final String rulePath) Add unit test for NewGlobalNode#getGlobalRuleNode Sep 21, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Oct 21, 2023
@Swastyy Swastyy self-assigned this Apr 15, 2024
@Swastyy Swastyy linked a pull request Apr 15, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swastyy Swastyy

Labels
good first issue in: test project: OSD2023 stale status: volunteer wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding Unit test for NewGlobalNode#getGlobalRuleNode Swastyy/shardingsphere
2 participants
@zhaojinchao95 @Swastyy