We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEAK_SCOPED_MUTEX_LOCK and WEAK_MUTEX_TRY_LOCK are introduced to allow the mutex to be a nullptr.
WEAK_SCOPED_MUTEX_LOCK
WEAK_MUTEX_TRY_LOCK
trafficserver/include/iocore/eventsystem/Lock.h
Lines 52 to 57 in 31c1592
Typical usage is below.
trafficserver/src/api/APIHook.cc
Lines 73 to 75 in 31c1592
However, if we take a look at the Continuation::handleEvent in this case, it has a release assert of the mutex.
Continuation::handleEvent
trafficserver/include/iocore/eventsystem/Continuation.h
Lines 223 to 229 in 31c1592
It looks like we don't have reason to use WEAK_ version to allow nullptr in many cases.
WEAK_
The text was updated successfully, but these errors were encountered:
Hmm, I need to think this through a bit. I'm referencing #5879 to keep track of related PRs.
Sorry, something went wrong.
duke8253
No branches or pull requests
WEAK_SCOPED_MUTEX_LOCK
andWEAK_MUTEX_TRY_LOCK
are introduced to allow the mutex to be a nullptr.trafficserver/include/iocore/eventsystem/Lock.h
Lines 52 to 57 in 31c1592
Typical usage is below.
trafficserver/src/api/APIHook.cc
Lines 73 to 75 in 31c1592
However, if we take a look at the
Continuation::handleEvent
in this case, it has a release assert of the mutex.trafficserver/include/iocore/eventsystem/Continuation.h
Lines 223 to 229 in 31c1592
It looks like we don't have reason to use
WEAK_
version to allow nullptr in many cases.The text was updated successfully, but these errors were encountered: