Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #115

Open
mnmkng opened this issue Jan 21, 2021 · 4 comments
Open

Fix broken links #115

mnmkng opened this issue Jan 21, 2021 · 4 comments

Comments

B4nan added a commit that referenced this issue Mar 15, 2021
The link to `PuppeteerPool` won't work as the page is no longer part of 1.0 sdk docs,
found a note about it being deprecated and replaced with `BrowserPool`, but i'd rather
let you handle that change as I don't fully understand all the differences.

Related: #115
@B4nan
Copy link
Member

B4nan commented Mar 15, 2021

ooops, should have been a PR :] reposting the commit message here:

The link to PuppeteerPool won't work as the page is no longer part of 1.0 sdk docs,
found a note about it being deprecated and replaced with BrowserPool, but i'd rather
let you handle that change as I don't fully understand all the differences.

@mnmkng
Copy link
Member Author

mnmkng commented Apr 21, 2021

@B4nan Is this still relevant?

@B4nan
Copy link
Member

B4nan commented Apr 21, 2021

Fixed the links for AutoscaledPool only, as said above, the link for PuppeteerPool is not valid in v1, so that goes to 404. Not sure how we wanna handle that, probably the mention about PuppeteerPool should be removed?

And apparently the docs (on web, not sdk docs) will need a rebuild, the AutoscaledPool is still not working - I fixed it only in this repo as I thought it is taken from here, but might be a duplicated content somewhere else.

Btw we might also make the old links just work (add redirects and keep the old url working too). I know how to do that in docusaurus v2, but there will be probably same/similar way to do so in v1 too.

e.g. this is how I am handling old URLs that were directy on the domain (/custom-driver), but now they are under /docs/custom-driver:

https://github.com/mikro-orm/mikro-orm/blob/master/docs/static/custom-driver/index.html

@mnmkng
Copy link
Member Author

mnmkng commented Apr 21, 2021

Redirects are not easy to do in v1. Will have to do it once we migrate to v2. I would point the invalid puppeteer pool link to https://github.com/apify/browser-pool for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants