Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] apify push with hooks #142

Open
pocesar opened this issue Jan 18, 2020 · 2 comments
Open

[feature] apify push with hooks #142

pocesar opened this issue Jan 18, 2020 · 2 comments
Labels
t-platform Issues with this label are in the ownership of the platform team.

Comments

@pocesar
Copy link

pocesar commented Jan 18, 2020

It's mostly an interop feature request, to be able to execute compilation/transpilation (babel/typescript), execute tests if any, then push to the platform. this ensures that you never push a broken / stale build. my use-case is compile to typescript, lint, run jest, then push

inspiration: https://www.npmjs.com/package/husky (for git) or "prepublish[Only]"

check package.json for a key that the apify cli could look for settings, like (there are a couple of packages that use this way, like parcel, browserslist, babel itself)

{
   "apify": {
    "prePush": "npm commands..."
   }
}

or maybe even reuse npm's prepublish as a quick way to get this done, and be this behavior by default, and using --no-hooks (or something that ignores the settings, like --force) to apify push

@drobnikj
Copy link
Member

If you are looking for a workaround, you can use any CI tool like GH actions. I wrote https://help.apify.com/en/articles/1861038-setting-up-continuous-integration-for-apify-actors-on-bitbucket some time ago how to do it on Bitbucket pipelines. I think it is a more common way, rather than using hooks.

@pocesar
Copy link
Author

pocesar commented Jan 20, 2020

that's definitely the way to go

@mtrunkat mtrunkat added the t-platform Issues with this label are in the ownership of the platform team. label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-platform Issues with this label are in the ownership of the platform team.
Projects
None yet
Development

No branches or pull requests

3 participants