Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apify_client._errors to apify_client.errors #158

Open
fnesveda opened this issue Oct 25, 2023 · 0 comments
Open

Move apify_client._errors to apify_client.errors #158

fnesveda opened this issue Oct 25, 2023 · 0 comments
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@fnesveda
Copy link
Member

We have some error subclasses like ApifyApiError defined in https://github.com/apify/apify-client-python/blob/master/src/apify_client/_errors.py, with the underscore suggesting it's a private submodule.

We have them documented in the docs, though, suggesting people should use them in their isinstance checks etc, which they should be able to, since the thrown errors should be a part of the public API of a module.

We should move them out of the private _errors submodule to a public errors submodule, to make it clear that these are OK to use by end users.

@fnesveda fnesveda added the debt Code quality improvement or decrease of technical debt. label Oct 25, 2023
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants