Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about SDK vs crawlee version mismatch #237

Closed
B4nan opened this issue Oct 5, 2023 · 0 comments · Fixed by #301
Closed

Warn about SDK vs crawlee version mismatch #237

B4nan opened this issue Oct 5, 2023 · 0 comments · Fixed by #301
Assignees
@B4nan
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone
76th sprint - Too...

Comments

@B4nan
Copy link
Member

B4nan commented Oct 5, 2023

Since the SDK depends on crawlee, users might configure their dependencies so those two don't fit each other, which ends up with multiple @crawlee/core installs, which in turn might cause weird issues, since there will be two global configs. This could potentially result in the crawlee storage methods (like Dataset.pushData) working with the memory storage even when on platform.

We should validate this in the Actor.init call, there needs to be a single crawlee installation.
@B4nan B4nan mentioned this issue Oct 5, 2023
Closed
1 task
@B4nan B4nan added the enhancement New feature or request. label Oct 5, 2023
@B4nan B4nan added this to the 74nd sprint - Tooling team milestone Oct 5, 2023
@B4nan B4nan self-assigned this Oct 5, 2023
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 23, 2023
B4nan added a commit that referenced this issue May 23, 2024
@B4nan
feat: validate crawlee versions in Actor.init
e3d71d0 
The SDK depends on `@crawlee/core`, but if the user installs an incompatible version of crawlee, they might end up with two installations of the `@crawlee/core` which means multiple static registers like the one for the global configuration, which breaks the integration, since the SDK will only touch the global config it sees, but it's a different one than the explicitly installed package.

Closes #237
@B4nan B4nan mentioned this issue May 23, 2024
Merged
B4nan added a commit that referenced this issue May 23, 2024
@B4nan
feat: validate crawlee versions in Actor.init
ecdcdab 
The SDK depends on `@crawlee/core`, but if the user installs an incompatible version of crawlee, they might end up with two installations of the `@crawlee/core` which means multiple static registers like the one for the global configuration, which breaks the integration, since the SDK will only touch the global config it sees, but it's a different one than the explicitly installed package.

Closes #237
B4nan added a commit that referenced this issue May 23, 2024
@B4nan
feat: validate crawlee versions in Actor.init (#301)
66ff6a9 
* feat: validate crawlee versions in `Actor.init`

The SDK depends on `@crawlee/core`, but if the user installs an incompatible version of crawlee, they might end up with two installations of the `@crawlee/core` which means multiple static registers like the one for the global configuration, which breaks the integration, since the SDK will only touch the global config it sees, but it's a different one than the explicitly installed package.

Closes #237

* normalize paths and declare missing dependency

* add more details to the error message

* support pnpm and yarn pnp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B4nan B4nan

Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
76th sprint - Tooling team
Development

Successfully merging a pull request may close this issue.

feat: validate crawlee versions in Actor.init apify/apify-sdk-js
1 participant
@B4nan