Adding puppeteer dependency in crawlee

[teammakdi]

Hi, I'm using Crawlee's Puppeteer crawler

I've imported crawlee via package.json like

{
   "crawlee": "^3.5.4"
}

Shall I be importing puppeteer in via my package.json as well?

I see puppeteer in crawlee's peer dependency but as optional https://www.npmjs.com/package/crawlee?activeTab=code

Issue is that puppeteer gets bumped very often with bug fixes and I've been stuck with puppeteer 21.1.x since I've imported it in my package.json.

Ideal expectation is that I just import Crawlee and bumping Crawlee bumps puppeteer as well as per its requirements/support.

[teammakdi]

Also on github puppeteer dev devenpency is ^21.2.1 https://github.com/apify/crawlee/blob/master/package.json#L97

However on npm it is <=21.1 https://www.npmjs.com/package/@crawlee/puppeteer?activeTab=code

[B4nan]

this is irrelevant, the first link is to the root dev dependencies, that does not represent any package

[B4nan]

its a peer dependency, you are responsible to install it and manage its versions, we dont want to dictate what version of puppeteer you want to use.

[teammakdi]

@B4nan

I get this error when i try to bump puppeteer

npm ERR! While resolving: crawlee@3.5.4
npm ERR! Found: puppeteer@21.3.5
npm ERR! node_modules/puppeteer
npm ERR!   puppeteer@"^21.3.5" from the root project
npm ERR!   peerOptional puppeteer@">= 9.x" from fingerprint-injector@2.1.39
npm ERR!   node_modules/fingerprint-injector
npm ERR!     fingerprint-injector@"^2.1.39" from the root project
npm ERR!     fingerprint-injector@"^2.0.5" from @crawlee/browser-pool@3.5.4
npm ERR!     node_modules/@crawlee/browser/node_modules/@crawlee/browser-pool
npm ERR!       @crawlee/browser-pool@"3.5.4" from @crawlee/browser@3.5.4
npm ERR!       node_modules/@crawlee/browser
npm ERR!         @crawlee/browser@"3.5.4" from @crawlee/playwright@3.5.4
npm ERR!         node_modules/@crawlee/playwright
npm ERR!         2 more (crawlee, @crawlee/puppeteer)
npm ERR!     2 more (@crawlee/browser-pool, @crawlee/browser-pool)
npm ERR!   1 more (puppeteer-extra)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional puppeteer@"<= 21.1" from crawlee@3.5.4
npm ERR! node_modules/crawlee
npm ERR!   crawlee@"^3.5.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: puppeteer@21.1.1
npm ERR! node_modules/puppeteer
npm ERR!   peerOptional puppeteer@"<= 21.1" from crawlee@3.5.4
npm ERR!   node_modules/crawlee
npm ERR!     crawlee@"^3.5.4" from the root project

[B4nan]

Hmm that's not really intentional, will fix that (unless they did something bad and broke things in the newer versions).

[teammakdi]

Just FYI,

Right now I'm using Crawlee ^3.5.4 and have also imported puppeteer ^21.1.1

And I'm trying to bump to latest puppeteer.

[B4nan]

you can install any version, this is just npm constraints check you can get around via some option

[teammakdi]

Cool. Yes there are flags to get it working.

As you mentioned is there any fix to be introduced? If not I'll close the discussion.