Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Activation flags which are rolled out to 100% turn them to true by default #33224

Closed
sneha122 opened this issue May 7, 2024 · 0 comments · Fixed by #33225 or #33283
Closed
Assignees
Labels
Activation - datasources issues related to activation projects Activation - learnability Activation - learnability BE Coders Pod Issues related to users writing code to fetch and update data Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo

Comments

@sneha122
Copy link
Contributor

sneha122 commented May 7, 2024

SubTasks

https://theappsmith.slack.com/archives/C05P3ME9MBR/p1715050713382359

@sneha122 sneha122 added Task A simple Todo Activation - datasources issues related to activation projects Activation - learnability Activation - learnability labels May 7, 2024
@sneha122 sneha122 self-assigned this May 7, 2024
@github-actions github-actions bot added the Integrations Pod Issues related to a specific integration label May 7, 2024
@sneha122 sneha122 added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label May 8, 2024
@github-actions github-actions bot added the BE Coders Pod Issues related to users writing code to fetch and update data label May 8, 2024
sneha122 added a commit that referenced this issue May 8, 2024
## Description
For the airgapped testing, we need to remove all the feature flags which
are already rolled out to 100% of the users. As part of this task, we
have 3 flags in activation/learnability initiatives:
1. rollout_js_enabled_one_click_binding_enabled
2. ab_learnability_ease_of_initial_use_enabled
3. ab_learnability_discoverability_collapse_all_except_data_enabled
4. rollout_remove_feature_walkthrough_enabled

As immediate measure, we are turning default values of these flags to be
true, later on we can plan to completely remove the flags from the code.


Fixes #`Issue Number`  
_or_  
Fixes [`Issue
URL`](#33224)
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8996740514>
> Commit: 0816933
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8996740514&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
@sneha122 sneha122 reopened this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activation - datasources issues related to activation projects Activation - learnability Activation - learnability BE Coders Pod Issues related to users writing code to fetch and update data Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo
Projects
None yet
1 participant