Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Changing font causes visual distortion; more noticeable than what used to happen on the base DP #33331

Open
1 task done
ramsaptami opened this issue May 9, 2024 · 7 comments
Labels
Anvil POD Issue related to Anvil project Bug Something isn't working Low An issue that is neither critical nor breaks a user flow WDS team

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented May 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

changing font causes visual distortion; more noticeable than what used to happen on the base DP

Steps To Reproduce

  1. Change app theme one by one as seen in the video and notice the visual "jiggle" widgets do to adjust spacing

Public Sample App

No response

Environment

Deploy Preview

Severity

High

Issue video log

https://www.loom.com/share/fd8ad97824324fe2b74c87a3d58bb526?sid=3539c3ff-46ff-4d26-a5d4-e1e9dbc44541

Version

cloud

@ramsaptami ramsaptami added Bug Something isn't working WDS team labels May 9, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview Low An issue that is neither critical nor breaks a user flow labels May 9, 2024
@github-actions github-actions bot added the Anvil POD Issue related to Anvil project label May 9, 2024
@ramsaptami ramsaptami added High This issue blocks a user from building or impacts a lot of users and removed Deploy Preview Issues found in Deploy Preview labels May 9, 2024
@ichik
Copy link
Contributor

ichik commented May 10, 2024

Seems like we're propagating changes to tokens in two steps rather than applying them everywhere at once?
@KelvinOm @riodeuno @jsartisan @marks0351 anything that we could do about it?

@ichik ichik removed their assignment May 10, 2024
@ichik ichik removed the High This issue blocks a user from building or impacts a lot of users label May 10, 2024
@jsartisan
Copy link
Contributor

I think the visual distortion is expected no? 🤔 Since different fonts have different character widths which is causing the width of widget change on font change. I am not sure what is the expectation here? @ichik @ramsaptami

@ramsaptami
Copy link
Contributor Author

@jsartisan there's 2 parts to the video, first bit shows behaviour on the widget selection DP & second half on the previous version of the base DP - you'll notice the transition is smoother on the latter.

@ichik
Copy link
Contributor

ichik commented May 10, 2024

@jsartisan it's about two reflows that happen. If you watch the video closely you can see that adjustments happens in two steps after typeface change.

@KelvinOm
Copy link
Collaborator

Related conversation #33374 (comment)

@ramsaptami
Copy link
Contributor Author

@jsartisan please add estimates if we're working on this; we can move this to the backlog if this isn't being picked up right now too

@KelvinOm
Copy link
Collaborator

@ramsaptami Moved task to new issues list because it's low priority and we'll postpone it for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anvil POD Issue related to Anvil project Bug Something isn't working Low An issue that is neither critical nor breaks a user flow WDS team
Projects
None yet
5 participants