Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded URLs in multiple places that may affect Self Hosting #59

Open
roughiain opened this issue Sep 27, 2023 · 2 comments
Open

Hard coded URLs in multiple places that may affect Self Hosting #59

roughiain opened this issue Sep 27, 2023 · 2 comments

Comments

@roughiain
Copy link

Looking at some of the code and have noticed that there are hardcoded urls referencing https://aptabase.com/ should they not be referencing EnvSettings.SelfBaseUrl so that self hosting works?

Or is the docker image for self-hosting based on a different repo/branch?

@goenning
Copy link
Member

The docker image is based on this repo, so this code ships on self hosted too.

for the program.cs, that because our homepage makes calls to the official hosting sites to check if the user is already authenticated, if they are, they see a “Dashboard” button instead of “Sign Up”. It’s irrelevant for self hosting, but also harmless.

The second use is me being lazy. I want to proxy requests to Gravatar for privacy reasons, and the easiest solution at that time was to use Vercel (which is where aptabase.com is hosted). But I guess it’s time to move away from thst and do the proxy within the container itself. Would you be interested in contributing a PR? :)

@roughiain
Copy link
Author

I will try get a PR through by Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants