Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device model for Android analytics #73

Open
roozbehzarei opened this issue Feb 3, 2024 · 12 comments
Open

Add device model for Android analytics #73

roozbehzarei opened this issue Feb 3, 2024 · 12 comments
Labels
feature request New feature or request

Comments

@roozbehzarei
Copy link

Device model could be retrieved using the Build class in Android. Refer to this article for more information.

@roozbehzarei
Copy link
Author

I see the following information are sent by the Kotlin SDK:
timestamp, sessionId, eventName, systemProps, props. Since systemProps holds the information related to the system, I can send a PR with deviceModel property added to the JSON response in case the website can process the data.

@goenning
Copy link
Member

goenning commented Feb 3, 2024

If you want to add that on a PR, I’m happy to merge it. The server will eventually support device model too, but until then it’ll simply ignore it

@roozbehzarei
Copy link
Author

roozbehzarei commented Feb 5, 2024

I assume the naming of JSON objects and properties are the same across all platforms? If so, what property name do you want me to chose for the device model?

@goenning
Copy link
Member

goenning commented Feb 5, 2024

deviceModel seems like a good name to me 👍

@roozbehzarei
Copy link
Author

PR: aptabase/aptabase-kotlin#3

Added deviceModel to the systemProps property in the JSON object. Feel free to make contact if you need any additional information added in the future.

@goenning
Copy link
Member

goenning commented Feb 5, 2024

I actually wanted to ask if it’s possible to add a Kotlin/Android dependency directly from GitHub, without having to publish to Maven.

and if that’s a common thing to do. The current process to publish to Maven is very tedious

@goenning
Copy link
Member

goenning commented Feb 5, 2024

And thanks for the PR, will review soon

@roozbehzarei
Copy link
Author

I actually wanted to ask if it’s possible to add a Kotlin/Android dependency directly from GitHub, without having to publish to Maven.

and if that’s a common thing to do. The current process to publish to Maven is very tedious

It's possible and somewhat common. While the most popular libs are all on Maven, there are still many hosted on GitHub. Anyone who wants to import a library from GitHub should add an additional repository in their project and the process doesn't introduce any issues.

If you're interested in doing so, I can make the required changes to the library to make it happen.

@goenning
Copy link
Member

goenning commented Feb 6, 2024

Yeah let’s do that! :)

@roozbehzarei
Copy link
Author

PR: aptabase/aptabase-kotlin#4

Make sure to read the PR description before merging.

@goenning
Copy link
Member

goenning commented Feb 7, 2024

Thanks @roozbehzarei do I need to do anything on https://jitpack.io/ ?

@roozbehzarei
Copy link
Author

Sure thing.
No, the process is automatic. Still, I will run a test as soon as the changes are merged to ensure everything works as expected.

@goenning goenning added the feature request New feature or request label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants