-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device model for Android analytics #73
Comments
I see the following information are sent by the Kotlin SDK: |
If you want to add that on a PR, I’m happy to merge it. The server will eventually support device model too, but until then it’ll simply ignore it |
I assume the naming of JSON objects and properties are the same across all platforms? If so, what property name do you want me to chose for the device model? |
deviceModel seems like a good name to me 👍 |
PR: aptabase/aptabase-kotlin#3 Added |
I actually wanted to ask if it’s possible to add a Kotlin/Android dependency directly from GitHub, without having to publish to Maven. and if that’s a common thing to do. The current process to publish to Maven is very tedious |
And thanks for the PR, will review soon |
It's possible and somewhat common. While the most popular libs are all on Maven, there are still many hosted on GitHub. Anyone who wants to import a library from GitHub should add an additional repository in their project and the process doesn't introduce any issues. If you're interested in doing so, I can make the required changes to the library to make it happen. |
Yeah let’s do that! :) |
PR: aptabase/aptabase-kotlin#4 Make sure to read the PR description before merging. |
Thanks @roozbehzarei do I need to do anything on https://jitpack.io/ ? |
Sure thing. |
Device model could be retrieved using the Build class in Android. Refer to this article for more information.
The text was updated successfully, but these errors were encountered: