Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace org.json.JSONObject vs GSON/Jackson/Moshi #214

Open
sandys opened this issue Sep 3, 2023 · 5 comments
Open

replace org.json.JSONObject vs GSON/Jackson/Moshi #214

sandys opened this issue Sep 3, 2023 · 5 comments

Comments

@sandys
Copy link
Contributor

sandys commented Sep 3, 2023

we use JSONObject in multiple places. If we can reduce amount of code using GSON/Jackson/Moshi - we should do that.

Performance is not the top criteria here.

@adi-kmt
Copy link

adi-kmt commented Sep 15, 2023

Some benchmarks you can have a look at.
I think Jackson does look better according to the above link.
Could work on this, if you want.

@sandys
Copy link
Contributor Author

sandys commented Sep 15, 2023

@kamathis4 that sounds good! this should be a relatively straight forward...but very impactful project if u do it.

P.S. dont forget to add testcases

@sandys
Copy link
Contributor Author

sandys commented Sep 15, 2023

@kamathis4 one of the reason we are preferring GSON/Moshi is because of #220

there is a very interesting path there to take!

@adi-kmt
Copy link

adi-kmt commented Sep 22, 2023

So you suggest moshi since it's easily interoperable with android?

@sandys
Copy link
Contributor Author

sandys commented Sep 22, 2023

@kamathis4 would love to hear your thoughts and evaluation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants