Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use FeedbackDataset in HF example #4805

Merged
merged 2 commits into from May 13, 2024
Merged

docs: use FeedbackDataset in HF example #4805

merged 2 commits into from May 13, 2024

Conversation

sdiazlor
Copy link
Contributor

@sdiazlor sdiazlor commented May 8, 2024

Description

screencapture-127-0-0-1-8000-getting-started-installation-deployments-huggingface-spaces-html-2024-05-08-14_03_04

Closes #4740

Type of change

(Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes.)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@sdiazlor sdiazlor requested a review from dvsrepo May 8, 2024 12:18
@sdiazlor sdiazlor linked an issue May 8, 2024 that may be closed by this pull request
[DOCS] Use feedback dataset example in quickstart #4740
Closed
dvsrepo
dvsrepo approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@dvsrepo dvsrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @sdiazlor! Just left two small suggestions

@sdiazlor sdiazlor changed the base branch from develop to main May 9, 2024 09:31
@sdiazlor sdiazlor merged commit a422e27 into main May 13, 2024
16 checks passed
@sdiazlor sdiazlor deleted the docs/use-feedback-dataset-example-in-quickstart branch May 13, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvsrepo dvsrepo dvsrepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Use feedback dataset example in quickstart
2 participants
@sdiazlor @dvsrepo