Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beam Search #30

Open
ZachNagengast opened this issue Feb 16, 2024 · 0 comments
Open

Beam Search #30

ZachNagengast opened this issue Feb 16, 2024 · 0 comments
Labels
needs model updates Requires associated model change

Comments

@ZachNagengast
Copy link
Contributor

Beam search on CoreML will require some model changes to work according to the reference implementation. This is mainly due to CoreML static shapes requiring a new model for each possible beam_size. We have some plans to deal with this so will keep this issue here for tracking purposes.

References

Openai implementation: https://github.com/openai/whisper/blob/ba3f3cd54b0e5b8ce1ab3de13e32122d0d5f98ab/whisper/decoding.py#L301-L404
@ZachNagengast ZachNagengast added the needs model updates Requires associated model change label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs model updates Requires associated model change
Projects
WhisperKit
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZachNagengast