New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Want to use AVCaptureSession buffers instead of AVAudioEngine #44
Comments
Thanks for the note @cgfarmer4! @ZachNagengast what do you think? |
Ah I just found this code ;) Decided against using
Going to see if I can try some tactics from this thread for my interface but seems hacky. |
@cgfarmer4 thanks for the effort looking into this. This looks promising, although I would also support an additional method that uses AVCaptureSession to generate audioSamples in case some folks already had easy access their apps AVCaptureDevice. There is nothing specifically tied to audioengine in the protocol, we'd just need to make sure it has handling for the various different platforms that don't have access to those apis (watchOS for example doesn't support it). Curious to see how your tests go and would be happy to integrate these back into the AudioProcessor depending on the results. |
Decided against using
|
Previously when I was working with https://gist.github.com/cgfarmer4/182d9d6d1cdf9d219ba0a4db6a23d745#file-capturedelegate-swift-L1-L46 |
Hey there!
First off, thanks so much for building this awesome library! Its a total pleasure to use and works great. Looking forward to the
Metal
update. In the meantime, I was curious if you all would accept a PR to allow forAVCaptureSession
to be used in theAudioProcessor
class instead ofAVAudioEngine
.I was thinking of creating a way to pass in a new setupEngine function that allowed for the
captureOutput
delegate to be used in place of theinstallTap
function. The reason I want to do this is it makes it easier to change the microphone in app instead of relying on the system default.AudioProcessor
? If so, Im happy to come up with a clean interface proposal.AudioProcessor
class and provide an alternatesetupEngine
function?The text was updated successfully, but these errors were encountered: