-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding error with system level extensions #17929
Labels
Comments
I believe we should be able to fix this just by deleting this block which renders the extra padding for extensions. |
14 tasks
Hey all, I've just put up a PR to fix this bug |
ishitasequeira
pushed a commit
that referenced
this issue
May 20, 2024
…17929) (#18207) * Remove CSS class `.cd-layout--extension` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove all usages of CSS class `.cd-layout--extension` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove unused prop `isExtension` from `<Layout />` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove unused property `extension` from type `Routes` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Fix linting error Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> --------- Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
rumstead
pushed a commit
to rumstead/argo-cd
that referenced
this issue
Jun 6, 2024
…rgoproj#17929) (argoproj#18207) * Remove CSS class `.cd-layout--extension` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove all usages of CSS class `.cd-layout--extension` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove unused prop `isExtension` from `<Layout />` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Remove unused property `extension` from type `Routes` Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> * Fix linting error Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> --------- Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Checklist:
argocd version
.Describe the bug
I'm developing a system level extension and I'm having an issue where there's a
sb-page-wrapper
class that has a padding of 230px that shifts my extension to the left as shown in this picture. I'd like to have my extension be able to use the space right next to the black nav bar on the left.There's also another div with style
.cd-layout--extension .cd-layout__content--sb-expanded
that haspadding-left: 230px
as well, which leads me to believe there's a bug where we're accidently applying the padding twice.To Reproduce
Create a system level extension with some text to see that it does renders with extra padding from the left.
Expected behavior
I would like to have my content rendered next to the side bar with no extra padding so that I can use all of the space provided like this:
Screenshots
Version
Note that I'm developing using
make start-local
off of master branch.Logs
The text was updated successfully, but these errors were encountered: