Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Source" pane is jumpy when typing repo name for a new app #15961

Closed
crenshaw-dev opened this issue Oct 13, 2023 · 3 comments · Fixed by #18227
Closed

"Source" pane is jumpy when typing repo name for a new app #15961

crenshaw-dev opened this issue Oct 13, 2023 · 3 comments · Fixed by #18227
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@crenshaw-dev
Copy link
Collaborator

Describe the bug

When I create a new app, each keystroke in the repo URL field causes a backend call and jumpiness in the UI.

To Reproduce

Create a new app and manually type the repo URL.

Expected behavior

I'd expect the UI to remain calm. Ideally, I'd expect the UI to validate what I've typed and not make a backend call if the URL has no chance of being a valid repo URL.

Screenshots

Screen.Recording.2023-10-13.at.1.24.32.PM.mov

Version

2.9.0-rc2
@crenshaw-dev crenshaw-dev added bug Something isn't working component:ui User interfaces bugs and enhancements labels Oct 13, 2023
@surajyadav1108
Copy link
Contributor

The jumpiness in the UI for keystrokes seems to be related to how the Autocomplete component in argo-ui is configured. To test this , I tried to set it up locally following the guidelines in the argo-ui repository. However, the build failed due to multiple compatibility issues with dependencies and versions listed in yarn.lock and package.json.

@surajyadav1108 surajyadav1108 mentioned this issue Jan 10, 2024
Open
@david-wu-octopus david-wu-octopus mentioned this issue May 15, 2024
Merged
14 tasks
@david-wu-octopus
Copy link
Contributor

Hi @crenshaw-dev, I've put up a PR to fix this issue

As git supports many URL formats (e.g., ssh, http, https, git), rather than validating the input is a valid repo URL, I've opted to use a debounce-based approach instead

Let me know if you have any feedback!

@surajyadav1108
Copy link
Contributor

Hi @crenshaw-dev, I've put up a PR to fix this issue

As git supports many URL formats (e.g., ssh, http, https, git), rather than validating the input is a valid repo URL, I've opted to use a debounce-based approach instead

Let me know if you have any feedback!

Simple and effective @david-wu-octopus 👏

pasha-codefresh pushed a commit that referenced this issue May 22, 2024
@david-wu-octopus
fix(ui): Fix jumpy "Source" panel when typing (issue #15961) (#18227)
462c9ec 
* Debounce `props.onAppChanged()` with a wait time of 500ms

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Increase debounce wait time to 800ms

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

* Fix linting error

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>

---------

Signed-off-by: David Wu <155603967+david-wu-octopus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): Fix jumpy "Source" panel when typing (issue #15961) david-wu-octopus/argo-cd
3 participants
@crenshaw-dev @surajyadav1108 @david-wu-octopus