Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting resource inclusion/exclusion #2591

Closed
aqeelat opened this issue Mar 19, 2024 · 5 comments
Closed

Allow setting resource inclusion/exclusion #2591

aqeelat opened this issue Mar 19, 2024 · 5 comments

Comments

@aqeelat
Copy link
Contributor

aqeelat commented Mar 19, 2024

Is your feature request related to a problem?

Since it is part of the declarative setup, it would be useful to add it to the chart as well

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

Related helm chart

argo-cd

Describe the solution you'd like

Adding an option for it in values.yaml

Describe alternatives you've considered

No response

Additional context

No response

@yu-croco
Copy link
Collaborator

Hi @aqeelat , thank you for your issue.
I will make PR for this.

FYI: The following works well for now, it's just not declared in values.yaml though. :)

configs:
  cm:
    resource.exclusions: |
      - apiGroups:
        - "*"
        kinds:
        - "*"
        clusters:
        - https://192.168.0.20

@pdrastil
Copy link
Member

Hi @yu-croco - the key is not part of CM as there is link to upstream with all supported attributes. The exclusions really depends what you have in cluster (crossplane, external-secrets, kyverno, etc. are typically here).

@yu-croco
Copy link
Collaborator

Hi @pdrastil , thank you for your comment.
doc says to edit the argocd-cm for the feature, so I thought we could handle with it.... 👀

To configure this, edit the argocd-cm config map:

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

@bsteinm2
Copy link

We also had issues with this while upgrading. I think moving this config to .Values.configs.cm makes sense, but without seeing this issue or looking here, I'm not sure how users are know that .Values.server.config was broken. Happy to help if this should be backwards compatible.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants