Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countour Tool: pixel perfect doesnt work after a straight line #4256

Closed
EthanHunt404 opened this issue Jan 3, 2024 · 6 comments · Fixed by #4429
Closed

Countour Tool: pixel perfect doesnt work after a straight line #4256

EthanHunt404 opened this issue Jan 3, 2024 · 6 comments · Fixed by #4429

Comments

@EthanHunt404
Copy link

EthanHunt404 commented Jan 3, 2024

this is an old issue regarding the countour tool, Its quite simple if you try doing a straight line with the shift key and continue after the pixel perfect feature stops working

Steps to recreate:

  • create a new document, any size, any color mode;
  • select the coutour tool(shortcut D);
  • draw a pixel anywere in the canvas, thats point A;
  • hold shift, aseprite will preview the line from point A to whatever other pixel your mouse in hovering;
  • press to confirm whenever you want but dont stop, immediatly start dragging it to continue drawing with the countour tool, you can stop holding shift now, it doesnt change whats happening
    its at this point the bug shows itself.

Aseprite and System version

  • Aseprite version: 1.3.2, Steam version
  • System: Windows 10 amd graphics card.
@EthanHunt404
Copy link
Author

1.3.2 behavior
https://www.loom.com/share/2588d1d2563c41a893680bef38944743
1.2.40 behavior
https://www.loom.com/share/aff49720730845aab15ac66b78ce32c0

i believe this happens ever since the start of 1.3 betas on steam too.

@Gasparoken
Copy link
Member

Thanks for reporting this. I was able to reproduce it.

@EthanHunt404
Copy link
Author

i just wanna say that the fix mister @Gasparoken proposed is working wonders, i compiled aseprite myself with the changes he proposed and it absolutely worked, not only countour tool, but the Pen and Eraser also were fixed.

@dacap dacap reopened this May 2, 2024
@EthanHunt404
Copy link
Author

EthanHunt404 commented May 10, 2024

why did you reopen this @dacap? also this original post was in a small scope, this is part of a bigger issue in the shift line behaviro, pen and eraser also repet the same behaviour.

@dacap dacap modified the milestones: v1.3.7, v1.3.8 May 21, 2024
@EthanHunt404
Copy link
Author

hey i want to comment on this again, im not sure why this has been moved to another milestone, the fix was suitable and it didnt seen to cause any other unintended effects, im relly invested on this specifically, cause its one of the main reasons i bought aseprite way back when, and it heavily hinders work, so i wanted to hear a reason to not implement what mr. @Gasparoken proposed.

@dacap
Copy link
Member

dacap commented May 28, 2024

@EthanHunt404 this was moved to the next milestone because v1.3.7 was already released with some important security updates. I didn’t test this yet but it will be included in the next version. The issue must be kept open until the fix is merged in main (that’s why I reopened it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
3 participants