Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review usage of Cosmos with Airflow 2.3 & older version of dbt #963

Closed
3 of 4 tasks
tatiana opened this issue May 15, 2024 · 4 comments
Closed
3 of 4 tasks

Review usage of Cosmos with Airflow 2.3 & older version of dbt #963

tatiana opened this issue May 15, 2024 · 4 comments
Assignees
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc epic-assigned triage-needed Items need to be reviewed / assigned to milestone
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented May 15, 2024

Context

We are aware there are conflicts between Airflow/dbt dependencies. And there is a cost involved with supporting older versions of Airflow, as seen in #944.

Acceptance criteria

  • Check which versions of Airflow are being used by Astronomer customers who use Cosmos
  • Make a survey with the community to check which versions of dbt & versions of Airflow they are using
  • Share the survey with the community
  • Make a decision about what is the oldest version of Airflow we want to support (the survey will be open for a while, we should close this ticket for now, and have a follow up task to check on this - Review dbt in Airflow Survey results #1024 )
@tatiana tatiana added this to the 1.5.0 milestone May 15, 2024
@dosubot dosubot bot added the area:dependencies Related to dependencies, like Python packages, library versions, etc label May 15, 2024
@tatiana tatiana changed the title Review usage of Cosmos with Airflow 2.3 Review usage of Cosmos with Airflow 2.3 & older version of dbt May 15, 2024
@tatiana tatiana added the triage-needed Items need to be reviewed / assigned to milestone label May 17, 2024
@tatiana tatiana self-assigned this May 17, 2024
@tatiana
Copy link
Collaborator Author

tatiana commented May 20, 2024

Initially I thought about doing a "/poll" in the #airflow-dbt channel. However, since it will disappear from Slack in 90 days, I decided to have this in a Google Form.

We already planned to have two questions, and this could be an opportunity to add more. I drafted a survey:

So far, I have shared with the following people for initial feedback:

@tatiana
Copy link
Collaborator Author

tatiana commented May 20, 2024

I queried Cosmos task runs since 1 January 2024 by Astronomer Customers, and identified which versions of Airflow and Runtime (that maps to Python versions), they used:

  • Airflow versions: 2.4.3 - 2.9.1
  • Runtime versions: 6.2.1 - 11.3.0 (Python 3.8 - Python 3.12, based on the docs)

Based exclusively on this, we could drop Airflow 2.3 from Cosmos test matrix. I also checked the usage since 1 May 2024, and unfortunately, Airflow 2.4.3 was still there.

Since the Astro Runtime will be moving to support every Airflow version for two years, 2.4 would still be in there. So, it is probably worth supporting it for the time being.

These diagrams show the percentages of tasks run with Cosmos operators per Airflow/Runtime version:

Image

Image

@tatiana
Copy link
Collaborator Author

tatiana commented May 21, 2024

Feedback from @cmarteepants:

  • Open question: How relevant is to know job titles?
  • How could we make more clear the granularity question - we agreed to give more options ("I don't know")

Feedback from @kaxil:

  • In future, some of this data could be automatically obtained by emitting metrics from Airflow deployments (e.g. versions), if the user consents

pankajkoti added a commit that referenced this issue May 22, 2024
Airflow 2.3 was released more than 2 years ago on Apr 30, 2022
and few of the apache-airflow providers are known to no longer
support it. We've observed cosmos users are not on Airflow 2.3 
based on the analysis in
#963 (comment)
and hence, to avoid maintenance & support efforts for an older version,
this PR drops Cosmos support for Airflow 2.3
@tatiana
Copy link
Collaborator Author

tatiana commented Jun 4, 2024

I addressed all the feedback and we announced the survey: https://bit.ly/dbt-airflow-survey-2024
Considering this ticket done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc epic-assigned triage-needed Items need to be reviewed / assigned to milestone
Projects
None yet
Development

No branches or pull requests

1 participant