Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album in track metadata is empty #17

Open
joerg65 opened this issue Apr 16, 2022 · 4 comments
Open

Album in track metadata is empty #17

joerg65 opened this issue Apr 16, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@joerg65
Copy link

joerg65 commented Apr 16, 2022

I try to get metadata with playerctl, there is song title and artist, but album stays empty.

playerctl metadata
chromium xesam:album               
chromium xesam:artist              Some Artist
chromium xesam:title               Some Title

As I have seen it is processed here in renderer.js:

                  track = {
                    title:
                      song.SNG_TITLE ||
                      song.LIVESTREAM_TITLE ||
                      song.EPISODE_TITLE ||
                      "",
                    artist:
                      song.ART_NAME ||
                      song.LIVESTREAM_TITLE ||
                      song.SHOW_NAME ||
                      "",
                    album: song.ALB_TITLE,
                    coverUrl: defaultCover,
                  },

Any idea how to solve? Note that I have compiled from source, but I don't have experience in js or node.

@aunetx aunetx self-assigned this May 1, 2022
@aunetx aunetx added the bug Something isn't working label May 1, 2022
@aunetx
Copy link
Owner

aunetx commented May 1, 2022

Thank you for the report!

Unfortunately I don't have much control over MPRIS, but I may find something by playing around with this part of the code :)

@faelau
Copy link

faelau commented Jun 24, 2022

Hello!

Maybe this patchh can help you: https://github.com/daltroaugusto/deezer-void/blob/master/patches/0001-MPRIS-interface.patch
This way we should also get an working album art!

@aunetx
Copy link
Owner

aunetx commented Jul 1, 2022

Hello!

Maybe this patchh can help you: https://github.com/daltroaugusto/deezer-void/blob/master/patches/0001-MPRIS-interface.patch This way we should also get an working album art!

Thank you very much! However this patch does not work anymore, as if I understood correctly Deezer got ride of the mpris library and I can't use this anymore... However I will see if I can copy some of its behaviour :)

@aunetx
Copy link
Owner

aunetx commented Jul 1, 2022

That's infeasible on my end... I really don't understand anything of the player itself (because it is all a blob compressed and minified js mess), and the electron server part does not seem to have access to the MPRIS part anymore.

Honestly, we will need some kind of "official" support before this could be done, imho...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants