Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] When saving predictor to a folder with an existing predictor, delete the old predictor #4195

Open
shchur opened this issue May 14, 2024 · 1 comment
Labels
enhancement New feature or request module: timeseries related to the timeseries module
Milestone

Comments

@shchur
Copy link
Collaborator

shchur commented May 14, 2024

Description

  • When the user sets TimeSeriesPredictor(path="folder/with/existing/predictor"), a lot of weird undocumented behaviors may occur (e.g., [BUG] TimeSeriesPredictor leaderboard EOFError #4150). We currently log a warning in this case, but it's often ignored by the users, leading to confusion. A cleaner option would be to delete all the files related to the old predictor.
@shchur shchur added the enhancement New feature or request label May 14, 2024
@Innixma Innixma added this to the 1.2 Release milestone May 15, 2024
@Innixma Innixma added the module: timeseries related to the timeseries module label May 15, 2024
@Innixma
Copy link
Contributor

Innixma commented May 15, 2024

Note that for Tabular, I don't delete the old files, but I believe the logic still works correctly without bugs in this case.

I'd lean towards trying to fix the bugs rather than brute-force deleting the old files. For instance, what if the pre-existing files aren't related to AutoGluon?

I'd be curious what the reason behind some of the bugs are. I expect it has to do with searching for the existence of files altering the logic in TimeSeries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module: timeseries related to the timeseries module
Projects
None yet
Development

No branches or pull requests

2 participants