Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with endless scrolling when there are has offset #859

Open
execut opened this issue Jun 22, 2021 · 6 comments
Open

Bug with endless scrolling when there are has offset #859

execut opened this issue Jun 22, 2021 · 6 comments

Comments

@execut
Copy link
Contributor

execut commented Jun 22, 2021

Steps to reproduce:

  1. Go to catalog list with auto pagination
  2. Add any ?offset=1 to url
  3. Scrolling down is endless
@execut
Copy link
Contributor Author

execut commented Jun 23, 2021

The situation repeats with zero offset. Disabling auto-pagination as if it was more than zero does not help here. It is necessary to refine the javascript to fix the error. I'll fix this error today

execut added a commit to execut/django-shop that referenced this issue Jun 23, 2021
@execut
Copy link
Contributor Author

execut commented Jun 23, 2021

Complete

@execut
Copy link
Contributor Author

execut commented Jun 23, 2021

I have a question. Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination? The rest_framework.pagination.PageNumberPagination would do this nice for it work. And would not entail such a mistake. What is the reason for this?

execut added a commit to execut/django-shop that referenced this issue Jun 25, 2021
@jrief
Copy link
Member

jrief commented Jun 25, 2021

Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination?

Because unless you use an explicit paginator, say just next and previous buttons, it is easier to handle.

@execut
Copy link
Contributor Author

execut commented Jun 28, 2021

Why use rest_framework.pagination.LimitOffsetPagination pagination in ProductListPagination?

Because unless you use an explicit paginator, say just next and previous buttons, it is easier to handle.

Got it

@jrief What do you think about task? How do you like my solution? Everything is fine?

@runnyren
Copy link

I have the same with shop system here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants