Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop code is not matching import statements generated by CDK v2 #1049

Open
Tracked by #1170
evgenyka opened this issue Jun 1, 2023 · 0 comments
Open
Tracked by #1170
Labels
bug This issue is a bug. cdk-v2 Issues related to or generated by the changes implemented in CDKv2 effort/medium Medium work item – a couple days of effort

Comments

@evgenyka
Copy link

evgenyka commented Jun 1, 2023

Describe the bug

The code in CDK workshop is outdated and not matching the latest CDK.

Expected Behavior

The updated import statements are:

import { Duration, Stack, StackProps } from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import { Construct } from 'constructs';

Current Behavior

The code in CDK workshop is outdated and not matching the latest CDK.

Reproduction Steps

Go to Project Structure page.
Find The main stack.
The import statements are:

import * as cdk from 'aws-cdk-lib';
import * as sns from 'aws-cdk-lib/aws-sns';
import * as subs from 'aws-cdk-lib/aws-sns-subscriptions';
import * as sqs from 'aws-cdk-lib/aws-sqs';

Possible Solution

Update the code in the Workshop to match the latest CDK version generated code.

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

TypeScript

@evgenyka evgenyka added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
@indrora indrora added effort/medium Medium work item – a couple days of effort cdk-v2 Issues related to or generated by the changes implemented in CDKv2 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. cdk-v2 Issues related to or generated by the changes implemented in CDKv2 effort/medium Medium work item – a couple days of effort
Projects
None yet
Development

No branches or pull requests

2 participants