Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of cdk (command) and npx cdk (command) #1188

Open
scanlonp opened this issue Sep 25, 2023 · 3 comments · May be fixed by #1400
Open

Inconsistent use of cdk (command) and npx cdk (command) #1188

scanlonp opened this issue Sep 25, 2023 · 3 comments · May be fixed by #1400
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@scanlonp
Copy link

scanlonp commented Sep 25, 2023

Describe the bug

In the pipelines workshop, deploy commands are done by npx cdk deploy. In all sections leading up to this, they are cdk deploy. This should not affect the behavior of the code, but is inconsistent.

I can open a pull for this.

Expected Behavior

Standardized CLI commands.

Current Behavior

Mix of CLI commands.

Reproduction Steps

This page
vs
this page

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

No response

Section

No response

Browser

No response

Language

Typescript

@scanlonp scanlonp added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 25, 2023
@ashishdhingra ashishdhingra added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@ashishdhingra
Copy link
Contributor

@scanlonp Thanks for pointing the inconsistency. Feel free to contribute PR with a fix. Please ensure the following:

  • Make the changes for all language workshops, for both English and Japanese languages
  • Ensure locally that omitting npx works.

Thanks,
Ashish

@ashishdhingra ashishdhingra added the effort/small Small work item – less than a day of effort label Apr 16, 2024
@stefanfreitag
Copy link
Contributor

@scanlonp @ashishdhingra I have some capacity left and if you both are fine, I can look into this.

@ashishdhingra
Copy link
Contributor

@scanlonp @ashishdhingra I have some capacity left and if you both are fine, I can look into this.

@stefanfreitag Sure. Thanks.

@stefanfreitag stefanfreitag linked a pull request Apr 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants