Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop description inaccurate #742

Open
Tracked by #1170
gopinaath opened this issue Oct 29, 2022 · 0 comments
Open
Tracked by #1170

Workshop description inaccurate #742

gopinaath opened this issue Oct 29, 2022 · 0 comments
Labels
bug This issue is a bug. documentation This is a problem with documentation. language/python Related to the Python workshop p2

Comments

@gopinaath
Copy link

Describe the bug

The output of cdk diff as described in the workshop is not in sync with actual output.

https://cdkworkshop.com/30-python/30-hello-cdk/200-lambda.html

Diff does not output "Parameters"

Expected Behavior

The text "It also synthesized a couple of CloudFormation parameters that are used by the toolkit to propagate the location of the handler code." should be removed.

Current Behavior

CDK Diff does not output "Parameters". Workshop documentation is out of sync with behavior of CDK

Reproduction Steps

https://cdkworkshop.com/30-python/30-hello-cdk/200-lambda.html

Possible Solution

Remove text:

"It also synthesized a couple of CloudFormation parameters that are used by the toolkit to propagate the location of the handler code."

Additional Information/Context

No response

CDK CLI Version

2.49.0 (build 793dd76)

Section

Python - Hello Lambda

Browser

No response

Language

Python

@gopinaath gopinaath added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 29, 2022
@indrora indrora added language/python Related to the Python workshop p2 documentation This is a problem with documentation. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. documentation This is a problem with documentation. language/python Related to the Python workshop p2
Projects
None yet
Development

No branches or pull requests

2 participants