Feature: make display chunks swithable #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wadabee
requested changes
May 23, 2024
frontend/src/i18n/ja/index.ts
Outdated
| @@ -67,6 +68,8 @@ const translation = { | |||
| sitemap: | |||
| 'サイトマップのURLを指定すると、そのサイトマップ内のサイトを自動的にスクレイピングして得られた情報がナレッジとして利用されます。', | |||
| file: 'アップロードしたファイルがナレッジとして利用されます。', | |||
| citeRetrievedContexts: | |||
| 'ユーザーの質問に答えるために取得したコンテキストを引用するかどうかを設定します。有効にすると、ユーザーは元のソースURLやファイルにアクセスできます。', | |||
There was a problem hiding this comment.
ON/OFF関係なくドキュメントを参考に回答を生成するので、「引用するかどうか」だと誤解を招きそうな表現です。
「引用情報として表示するかどうか」だといかがでしょうか？
| @@ -45,11 +45,15 @@ def post_message(request: Request, chat_input: ChatInput): | |||
|
|
|||
|
|
|||
| @router.post( | |||
| "/conversation/related-documents", response_model=list[RelatedDocumentsOutput] | |||
| "/conversation/related-documents", | |||
| response_model=list[RelatedDocumentsOutput] | None, | |||
There was a problem hiding this comment.
レスポンスについて、フロントエンド側の型情報も修正をお願いします！
frontend/src/pages/BotEditPage.tsx
Outdated
Comment on lines
479
to
490
| <div className="mt-2"> | ||
| <div className="font-semibold"> | ||
| {t('bot.label.citeRetrievedContexts')} | ||
| </div> | ||
| <div className="text-sm text-aws-font-color/50"> | ||
| {t('bot.help.knowledge.citeRetrievedContexts')} | ||
| </div> | ||
| <Toggle | ||
| value={displayRetrievedChunks} | ||
| onChange={setDisplayRetrievedChunks} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
スイッチが下にはみ出していて収まりが悪いので、以下のように修正をお願いしますmm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #248
Description of changes:
GET related-documentsreturns nullused_chunksin the response ofGET /conversations/<conv-id>will be nullBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.