Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] [Task Definition Secrets File]: S3 File with Secrets defined with valueFrom #2347

Open
d10zero opened this issue May 2, 2024 · 0 comments
Labels
Proposed Community submitted issue

Comments

@d10zero
Copy link

d10zero commented May 2, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
ECS task definitions container definitions currently support an environmentFile to define environment variables. I am requesting a similar parameter secretsFile that allows the user to define secrets within a file. i.e. instead of the format in the file to be KEY=VALUE, the format can be KEY=SECRETS_ARN i.e. KEY=arn::aws::secretsmanager:..., the same way the current key/valueFrom works directly in the secrets parameter.

Another possible solution would be to add the ability to specify an entire secret manager to include, instead of each individual secret.

Which service(s) is this request for?
ECS, Fargate

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
We reached the 64 KB task definition size limit because too many secrets were defined. This was only an issue because the valueFrom must be the entire ARN, which is very long. The secretFile will solve the issue of too many secrets, while keeping the key/values managed through secrets manager.

Are you currently working around this issue?
No

Additional context
Anything else we should know?

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

@d10zero d10zero added the Proposed Community submitted issue label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

1 participant