Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare-metal installation instructions need to be updated #582

Open
slbayer opened this issue Feb 23, 2022 · 0 comments
Open

Bare-metal installation instructions need to be updated #582

slbayer opened this issue Feb 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@slbayer
Copy link

slbayer commented Feb 23, 2022

Summary
The bare metal installation instructions are out of date and incomplete.

Additional context
The bare metal installation instructions on the page docs/installation.md needs to be updated. The issues I note are:

  • The documentation implies that PyPDF2 requires Python 2.7, but that appears not to be the case; Python 3.7 - 3.9, at least, all run PyPDF2 without problems.
  • The header detector uses a model which requires scikit-learn, but that package isn't on the list of things to install in the bare metal instructions. The version of scikit-learn that's required is 0.21.3; that's the version that the model was pickled with, and the current version no longer has the same symbols.
  • The TableDetection2Script.py script requires tabula, but that package isn't on the list of things to install in the bare metal instructions.
  • There's a copy-paste error in the MacOS version of the instructions: (pdfminer and camelot) is a parenthetical under both the Python 2 and Python 3 dependency instructions, and it can't be both. In fact, there are no longer any Python 2 dependencies, as far as I can tell.

In fact, because there are no Python 2 dependencies, it's now possible to install into a virtual environment and run from there, at least on the Mac.

Also, FYI, I used macports instead of brew and built my Python 3 virtual environment using a Python 3 download from python.org rather than a macports python, and everything seems to work just fine, which was a very pleasant surprise.

@slbayer slbayer added the bug Something isn't working label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant