Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kara] Attumen always selecting Nightmares HP amount on merge #18831

Open
balleny opened this issue Apr 27, 2024 · 2 comments
Open

[Kara] Attumen always selecting Nightmares HP amount on merge #18831

balleny opened this issue Apr 27, 2024 · 2 comments

Comments

@balleny
Copy link
Contributor

balleny commented Apr 27, 2024

Current Behaviour

when either attumen or midnight reaches 25%, they merge and get the % hp of midnight

Expected Blizzlike Behaviour

once either of them reaches 25%, they should merge and get the HP of the highest total of either of them

Source

https://wowtbc.gg/boss-guides/karazhan/

Steps to reproduce the problem

damage only midnight, they will merge into midnights hp

Extra Notes

https://www.wowhead.com/wotlk/npc=16152/attumen-the-huntsman

AC rev. hash/commit

chromiecraft@482f4c9

Operating system

Ubuntu 20.04

Custom changes or Modules

chromiecraft

@balleny
Copy link
Contributor Author

balleny commented Apr 27, 2024

@sogladev
Copy link
Contributor

some sources I looked at:

Classic TBC
https://www.youtube.com/watch?v=D8OZU8bg6lk
Midnight initial hp 379.4k
damage to midnight to 25%, spawned hp visible 379165
https://youtu.be/D8OZU8bg6lk?si=dY2sCCbLbLj2NvJX&t=1271

non-archived WCL log https://classic.warcraftlogs.com/reports/k1XYj4gwa8cV3FCm#fight=5&view=replay

Classic TBC
spawns 100% hp
https://youtu.be/kul6efg1hZA?si=N04-yIn3G1E2JeDC&t=150

Tested:

Attunement
1:
Hit midnight to 200k/265k
Attument to 25% hp 25k
result 200k/265k

2:
Hit attumene to 202k/265k
Midnight to 65k
result 202k /265k

3:
Hit attument to 100k
Hit midnight to 65k
result Attumen spawns with low hp 165k/265k

?

they should merge and get the HP of the highest total of either of them

I'm confused by the wording. What is the expected behavior?
Should spawn with remaining midnight hp + attunement hp?
1: 25k+200k= 225k/225k
2: 202K + 65k = 267k/267k
3: 100k+65k = 165k/165k

fix could be changing this

if (midnight->GetHealth() > me->GetHealth())

to

summon->SetMaxHealth(me->GetHealth() + midnight->GetHealth());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants