Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings and logs in the console when using on watch #58

Open
bencallis opened this issue Jun 24, 2020 · 5 comments
Open

Warnings and logs in the console when using on watch #58

bencallis opened this issue Jun 24, 2020 · 5 comments
Assignees

Comments

@bencallis
Copy link

Describe the bug
When using the stepper view there are several warnings in the logs. Performance to render the view is also somewhat slow which could be related to the warnings.

Bound preference HeightPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference VerticalHeightPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Bound preference WidthPreference tried to update multiple times per frame.
Intermediate Divider Height [5: 19.5, 6: 19.5, 12: 19.5, 11: 19.5, 14: 19.5, 3: 19.5, 2: 19.5, 7: 19.5, 10: 19.5, 0: 19.5, 9: 19.5, 13: 19.5, 8: 19.5, 1: 19.5, 4: 19.5]
Height of Divider [0: 628.5]
Final Line Height 609.0

The StepperView is contained within a ScrollView and VStack

            ScrollView {
                VStack {
                    makeStepperView()
                    Text("Sample label 😎").font(.caption)
                }.padding(.bottom)
            }
            Button(action: handleStartTap) { Text("Start") }
        }

Info (please complete the following information):

  • Device: 6.2 Simulator and device on 6.2
  • Pod Version 1.4.1
@the-welcome-bot
Copy link

Welcome to the project! Thankyou and congarts for your first PR on this project. We will review it soon! Till then you can checkout the ReadMe for more details on it. Hope you have a great time here :)

@badrinathvm
Copy link
Owner

@bencallis Thank you for creating the issue and appreciate all your effort in checking StepperView. I am looking over it and update you shortly.

@badrinathvm
Copy link
Owner

badrinathvm commented Jun 25, 2020

@bencallis Can you try below approach ? Looks like ScrollView is relayouting it's child views

   @State private var isShowStepperView = false
    ScrollView {
                VStack {
                  if isShowStepperView {
                    makeStepperView()
                    Text("Sample label 😎").font(.caption)
                 }
                }.padding(.bottom)
             }
     }.onAppear { self.isShowStepperView = true }
     Button(action: handleStartTap) { Text("Start") }

@bencallis
Copy link
Author

@badrinathvm just tried this and I'm still getting the same warnings.

@badrinathvm
Copy link
Owner

badrinathvm commented Jun 28, 2020

@bencallis i am investigating more , looks like I need to adopt LazyVStack to hinder the performance issues. Let me test this on Xcode 12 beta and keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants