Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is an issue with Cart Rule Marketing Time regarding the saving of Date and Time. #9763

Closed
1 task done
ashishkumar-webkul opened this issue May 7, 2024 · 1 comment
Assignees
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@ashishkumar-webkul
Copy link
Collaborator

Terms

  • Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected

Master

Issue Description

When creating a new rule in Cart Rule without filling in the Marketing Time details and saving the information, an issue arises with the start time and end time format on the Cart Rule Page. Additionally, when editing the cart rule and attempting to save again, the Marketing Time validation appears. Consequently, we are unable to save the Cart Rule.

Preconditions

  1. Admin must logged in.

Steps to reproduce

  1. Go to Admin -> Marketing -> Promotions -> Cart Rule.
  2. Create a new cart rule and fill all the details except the Marketing Time.
  3. Save the details.
  4. Check Cart Rule Page -> Start and End Row -> Date & Time Format Issue.
  5. Now edit the same Rule and save it -> We are uable to save the rule -> Market time validation issue and format issue.

Expected Result

  1. If we have created a cart rule without marketing time, then start and end must be empty.
  2. On Editing it must appear blank and we should be able to save them.

Actual Result

Please check the video for reference.

Video

Cart.rule.mp4

Screenshots

No response

Additional context

No response

@ashishkumar-webkul ashishkumar-webkul added the Bug Something isn't working. label May 7, 2024
@amit-webkul amit-webkul self-assigned this May 8, 2024
amit-webkul added a commit to amit-webkul/bagisto that referenced this issue May 8, 2024
@amit-webkul amit-webkul added the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label May 8, 2024
@ashishkumar-webkul
Copy link
Collaborator Author

Checked and Found that the issue has been fixed and working fine. Please check the video for reference.

Video

Cart.Rule.mp4

jitendra-webkul added a commit that referenced this issue May 14, 2024
@jitendra-webkul jitendra-webkul added the Bug Fixed When bug issue is fixed. label May 14, 2024
@devansh-webkul devansh-webkul removed the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

4 participants