Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Line Items Quantity and createCartifNotFound #49

Open
osseonews opened this issue Apr 20, 2023 · 0 comments
Open

Add Line Items Quantity and createCartifNotFound #49

osseonews opened this issue Apr 20, 2023 · 0 comments

Comments

@osseonews
Copy link

First off all, awesome library. I've always wondered why nobody developed a production-ready shopping cart in React-query that can easily be imported into any project. Anyway, 2 quick questions:

  1. addLineItemstoCart: This just assumes that someone adds 1 of the item to the cart. But, vast majority of time, people want to add a specific quantity the cart via some quantity selector or input. So there should be a way to add a quantity of the item when adding line items to cart.
  2. createCartifNotFound - not clear how this works. In shopify example in the hooks index it's set to true but then in the fetcher fetchCart, you have a cart is not defined check? Won't the cart always get created now if createcartifnotfound is true? Or how is this used exactly? When is the cart created, if it is not found?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant