Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading Likes overwrites Posts + Reblogs archive without warning? #115

Open
ghost opened this issue Dec 4, 2018 · 5 comments
Open
Labels

Comments

@ghost
Copy link

ghost commented Dec 4, 2018

If so that's annoying, will have to archive the bulk of the blog again now. Could at least be a note in the readme, or better it could do as expected and archive Likes to <blog-name-here>_likes.

@nightpool
Copy link

or save them under a likes sub-directory

@bbolli
Copy link
Owner

bbolli commented Dec 5, 2018

I'm pretty sure that the script doesn't just delete or overwrite stuff. What was the sequence of commands you executed?

@cebtenzzre
Copy link
Collaborator

There should be a way of marking the difference in the filesystem so that the program can detect an accidental overwrite. It would also be helpful for the index.html to tell you which type of archive/mirror it is, to avoid potential confusion.

@ghost
Copy link
Author

ghost commented Dec 6, 2018

python tumblr_backup.py <blog-name>

..then I went into the directory <blog-name>/archive/ and opened some months to check that it had worked; everything seemed fine. Then

python tumblr_backup.py --likes <blog-name>

..and not seeing where the Likes were stored, opening the same months' listings files now showed the Likes instead of my original posts.

ETA: I'm on Mac OS if that helps, maybe on Windows (which the readme instructions were for) the script behaves differently to prevent index.html etc from being overwritten?

@ann4belle
Copy link

Unless you're liking your own posts, it won't overwrite the posts, nor will it break any links to images or whatnot, however it will overwrite the index.html files - meaning your posts are still there, but you have to open each post manually. As others have said you should save likes and posts/reblogs in separate directories, or at least save one in a subdirectory of the other.

@cebtenzzre cebtenzzre added the bug label Aug 31, 2020
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Sep 28, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Sep 29, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Sep 30, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Sep 30, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Sep 30, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Oct 2, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Oct 8, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Oct 17, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Oct 20, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup --
redundant, but sometimes more convenient.
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Oct 22, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup
- Fix incorrectly sorted imports
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Nov 25, 2020
Fixes bbolli#115

Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup
- Fix incorrectly sorted imports
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Jan 17, 2021
Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup
- Fix incorrectly sorted imports
- Use lists in a few places for consistency with JSON
- Set before to oldest_tstamp even without --period
- Fix argument check to allow --auto 0
- Pass all path parts to open_text in save_post to ensure mkdir

Fixes bbolli#115
cebtenzzre added a commit to cebtenzzre/tumblr-utils that referenced this issue Apr 9, 2021
Included revisions:
- Allow setting options in BACKUP_CHANGING_OPTIONS to match the backup
- Fix incorrectly sorted imports
- Use lists in a few places for consistency with JSON
- Set before to oldest_tstamp even without --period
- Fix argument check to allow --auto 0
- Pass all path parts to open_text in save_post to ensure mkdir

Fixes bbolli#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants