Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck action not in ci job #1017

Open
kwanhur opened this issue Feb 21, 2022 · 2 comments
Open

staticcheck action not in ci job #1017

kwanhur opened this issue Feb 21, 2022 · 2 comments

Comments

@kwanhur
Copy link
Contributor

kwanhur commented Feb 21, 2022

staticcheck had been used in bfe, but it doesn't exist in ci job steps.

Add step staticcheck on pull request and push develop, helps to improve quality of codes.

marketplace here, but it's under MIT license.
Before using it, any license conflicts and CNCF policy limitations should take a care.

  • bfe under Apache License 2.0 and CNCF sandbox project
@kwanhur
Copy link
Contributor Author

kwanhur commented Feb 25, 2022

Another way, just add one step run with staticcheck binary. I think it hasn't any conflicts.

@kwanhur
Copy link
Contributor Author

kwanhur commented Mar 3, 2022

Advice adding staticcheck into pre-commit.

@kwanhur kwanhur mentioned this issue Mar 6, 2022
Merged
@kwanhur kwanhur mentioned this issue Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwanhur