Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Side Channel Attack on non-constant time Comparison #997

Open
nevercodecorrect opened this issue Apr 7, 2024 · 1 comment
Open

Comments

@nevercodecorrect
Copy link

nevercodecorrect commented Apr 7, 2024

  • pyspider version: 0.3.10
  • Operating system: Ubuntu-22.04
  • Start up command:

Expected behavior

The vulnerable code is here, the password comparison should use a constant time algorithm

Actual behavior

The vulnerable code is here. An attacker could leverage the differences between the execution time to recover the secrets. String comparison == is not a constant implementation, the execution time may vary based on how many characters are matched. A constant-time implementation would be recommended.
A more detailed explanation could be found here

@flowerone
Copy link

flowerone commented Apr 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants