You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's wrong?
Edit domain is very picky about values. As soon as a set of values changes, it forgets all settings connected with that variable. The widget even forgets about
This seems to be the issue of #6659. In #6415 we fixed widget so that it uses schema-only hints instead of contexts, so I was surprised by #6659. Indeed our handling if categorical variable is very strict.
How can we reproduce the problem?
Take a data set with a categorical variable. Edit its name in Edit domain. Save the workflow.
Add a value into the data set. Reload workflow. Notice that rename is lost.
Remove the added value. Reload workflow. Notice that it is renamed again.
This behavior does make sense, because stored hints look like this after playing:
Each categorical variable is matched with name and all values. Is this too strict? Should we leave it like this or can we do anything else? This smells of contexts. :)
The text was updated successfully, but these errors were encountered:
I would say that any applicable hint should be reused. Adding values should be acceptable. Perhaps even renaming values that no longer exist - it's just a hint after all, so if a renamed value is removed, it won't be renamed and that's it.
To me it doesn't smell of contexts. :) There, the problem was that different contexts matched, and we couldn't define a rule that would work in all cases. Here, it's just about the strictness of matching or, actually, about treating hints as loosely as possible.
What's wrong?
Edit domain is very picky about values. As soon as a set of values changes, it forgets all settings connected with that variable. The widget even forgets about
This seems to be the issue of #6659. In #6415 we fixed widget so that it uses schema-only hints instead of contexts, so I was surprised by #6659. Indeed our handling if categorical variable is very strict.
How can we reproduce the problem?
This behavior does make sense, because stored hints look like this after playing:
Each categorical variable is matched with name and all values. Is this too strict? Should we leave it like this or can we do anything else? This smells of contexts. :)
The text was updated successfully, but these errors were encountered: