Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency converter is confused by number suffixes (multipliers) #1399

Closed
Tracked by #1494 ...
SaltfishAmi opened this issue Oct 27, 2023 · 1 comment · Fixed by #1793
Closed
Tracked by #1494 ...

Currency converter is confused by number suffixes (multipliers) #1399

SaltfishAmi opened this issue Oct 27, 2023 · 1 comment · Fixed by #1793

Comments

@SaltfishAmi
Copy link
Contributor

SaltfishAmi commented Oct 27, 2023

An interesting example:

image

(Hovering over 8 does not have any effect)


image

I am looking for jobs in Japan (就活), and above two are actual examples of company information (not made up by me!).

Although I do think some of these multipliers look really weird, like, why use western 10^3 based multipliers when you write in Japanese??

余談ですが, in China, we write 1万元 or 1億元, we also write ¥10k or ¥100m, but I never see anyone write 10千元 or 100百万元 ... if a company has only 1,000 CNY of capital, we would write 0.1万元. I don't know the conventions in Japan but this really looks ... hmmm ... westernized.

@SaltfishAmi SaltfishAmi changed the title Currency converter is confused by number suffixes Currency converter is confused by number suffixes (multipliers) Oct 27, 2023
@birtles
Copy link
Member

birtles commented Oct 28, 2023

Yeah, those a really odd. I recently fixed a bug so that 39,800万円 is recognized which I encountered here: https://www.athome.co.jp/kodate/1008941087/

I'm not sure if the thinking there is that real estate figures are typically quoted in 万円 so 39,800万円 is more natural to talk about than 3.98億円?

I haven't released a version with that fix yet, however.

However, 123,456,789百万円 seems like a suspicious number for 売上高! I think someone might be cooking the books. Best to steer clear of that company!

I'll see what I can do about the other cases here. For my testing, here they are as text:

  • 123,456,789百万円
  • 11,786百万円
  • 3,307,675千円

I notice that last one already works on the latest trunk build (i.e. will be fixed in the next release).

Good luck with your 就活!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants