Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a custom tick thread #326

Open
liamflannery opened this issue Apr 2, 2024 · 2 comments
Open

Adding a custom tick thread #326

liamflannery opened this issue Apr 2, 2024 · 2 comments

Comments

@liamflannery
Copy link
Contributor

In my project I've changed the addon so that it runs the ticks based on my custom in game minute.
Would this be something that's worthing creating a pull request for?

Like you would change this dropdown to In Game Minute or Custom
image

and then maybe have a "tick source" export node that you can drag in and it will connect to the ticked signal within that node.
Was thinking this might help with performance.

@bitbrain
Copy link
Owner

bitbrain commented Apr 4, 2024

Seems to be a duplicate of #267 - my point in #267 (comment) was that one could simply set the process mode (of the Godot node itself) to disabled and then tick the tree manually. Is there a good reason why we cannot do that instead?

@liamflannery
Copy link
Contributor Author

Sorry didn't see 267, they can definitely do that in the same way I just connected the tree to a signal, it just doesn't seem like the intended/supported usage. I was thinking it could be something you point to when people bring up the performance concerns of the tree getting ticked every frame.

I don't think this is a huge issue though because it's not that hard to do for yourself, I just have the code there and can make a pull request if you were interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants