Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: GUIX closure contains too much unnecessary stuff #30042

Open
laanwj opened this issue May 5, 2024 · 1 comment
Open

upstream: GUIX closure contains too much unnecessary stuff #30042

laanwj opened this issue May 5, 2024 · 1 comment

Comments

@laanwj
Copy link
Member

laanwj commented May 5, 2024

The minimum guix closure contains X11 libraries, graphviz, as well as LaTeX and associated fonts. They should be unnecessary for minimum set of packages needed to build. Especially on slower CPUs (eg current RISC-V cores, qemu) it results in a large slowdown, it's also bad from a "minimum trusted set" point of view.

They're pulled in by guix-manual, as well as sometimes, package-specific documentation. Unfortunately, documentation is not behind an optional flag at the moment so there's nothing we can do at our build system level. Our manifest.scm already contains nothing that depends on them, and they're not part of our build environment.

Upstream issues about it (will update when i come across more):
https://issues.guix.gnu.org/issue/63050

@fanquake
Copy link
Member

Related upstream change: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824.

fanquake added a commit to fanquake/bitcoin that referenced this issue Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)
Kernel Headers 6.1.80 -> 6.1.92
Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit to fanquake/bitcoin that referenced this issue Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)
Kernel Headers 6.1.80 -> 6.1.92
Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit to fanquake/bitcoin that referenced this issue Jun 5, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)

git-minimal 2.41.0 -> 2.45.1
Kernel Headers 6.1.80 -> 6.1.92
moreutils 0.68 -> 0.69

Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit to fanquake/bitcoin that referenced this issue Jun 6, 2024
Includes:
LLVM 18.1.x (bitcoin#30201)
GCC 13.x (bitcoin#29881)

git-minimal 2.41.0 -> 2.45.1
Kernel Headers 6.1.80 -> 6.1.92
moreutils 0.68 -> 0.69

Commits like
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824,
which should improve the bootstrap situation (bitcoin#30042).
fanquake added a commit that referenced this issue Jun 8, 2024
…b8c73efed126

2599655 guix: bump time-machine to f0bb724211872cd6158fce6162e0b8c73efed126 (fanquake)

Pull request description:

  Includes:
  LLVM 18.1.x (#30201)
  GCC 13.x (#29881)

  git-minimal 2.41.0 -> 2.45.1
  Kernel Headers 6.1.80 -> 6.1.92
  moreutils 0.68 -> 0.69

  Commits like https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7b0f145802f0c2c785014293d748721678fef824, which should improve the bootstrap situation (#30042). This can somewhat be visualised by comparing the (simplified) dependencies of guix itself, between the two time-machines.

  Master:
  ![master_2](https://github.com/bitcoin/bitcoin/assets/863730/714402a2-345e-43c7-974b-5112d03d44c2)

  PR:
  ![pr](https://github.com/bitcoin/bitcoin/assets/863730/7079a155-e013-4d59-9ea1-21a64d71e2d8)

  Note that in the case of this PR, we are better off, no-longer having to build a number of tex packages, ruby, cairo, graphics libs, openssl 1.x etc.

ACKs for top commit:
  TheCharlatan:
    ACK 2599655

Tree-SHA512: 9c5675a5d563c17744c89c8a392bc7865aa1c9e71a5e3044c23f31e51458dac28c0c238d2055c86dc732df595dae60bcbc8b85266b23b7991c4c770d56f7d23a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants