Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis-cluster] Possibility to add labels on created PVC #25894

Closed
ammirator-administrator opened this issue May 15, 2024 · 4 comments · Fixed by #25901
Closed

[bitnami/redis-cluster] Possibility to add labels on created PVC #25894

ammirator-administrator opened this issue May 15, 2024 · 4 comments · Fixed by #25901

Comments

@ammirator-administrator
Copy link
Contributor

Name and Version

bitnami/redis-cluster latest

What is the problem this feature will solve?

Add labels on PVC for all cluster pvc

What is the feature you are proposing to solve the problem?

Ad the moment to add a label you have to run separate command with kubectl, it would be nice to have this as a helm chart field same as we have in other charts from bitnami, I'm not sure why this one doesn't follow this

What alternatives have you considered?

just by adding manually, but is not that friendly

@ammirator-administrator
Copy link
Contributor Author

I see this line of code in the volumeClaimTemplates but what it does I'm not sure, and how to pass custom labels there

In the defaultValues in helm chart I do not see a persistence.labels field , Is that even possible with current setup?

  volumeClaimTemplates:
    - metadata:
        name: redis-data
        labels: {{- include "common.labels.matchLabels" ( dict "customLabels" .Values.commonLabels "context" $ ) | nindent 10 }}

@ammirator-administrator
Copy link
Contributor Author

@javsalgar
I opened a PR for that can you please review and let me know if is good, should be a easy merge

#25901

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

@ammirator-administrator
Copy link
Contributor Author

@carrodher
Can I get a review on the PR, should be a quick one but I do not see any activity from the bitnami folks at all on it

@javsalgar javsalgar added the on-hold Issues or Pull Requests with this label will never be considered stale label May 20, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 20, 2024
@github-actions github-actions bot added solved and removed on-hold Issues or Pull Requests with this label will never be considered stale labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants